[BUGFIX beta] Ensure wrapped errors are logged properly. #10475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this? |
|
These are rough examples of some existing tests for the router error logging: https://github.com/emberjs/ember.js/blob/master/packages/ember/tests/routing/basic_test.js#L3176-3239 |
tonight or tomorrow yes |
ember-data and ic-ajax tag rejections with jqxhr’s with the original error when possible. This error is appended as jqxhr.errorThrown. Logging this error, dramatically improves debugability of request related transition failures
rwjblue
force-pushed
the
log-error-error-thrown
branch
from
7cbe024 to
cd9c472
Compare
rwjblue
changed the title
|
Added test, should be good to go when Travis is happy. |
rwjblue
added a commit
that referenced
this pull request
Feb 16, 2015
[BUGFIX beta] Ensure wrapped errors are logged properly.
|
Pulled into beta channel for 1.11.0-beta.3. |
|
danke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ember-data and ic-ajax tag rejections with jqxhr’s with the original error when possible. This error is appended as jqxhr.errorThrown. Logging this error, dramatically improves debugability of request related transition failures
before:
after:
